Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add privacy manifest #48

Merged
merged 3 commits into from
Apr 8, 2024
Merged

fix: add privacy manifest #48

merged 3 commits into from
Apr 8, 2024

Conversation

bgiori
Copy link
Collaborator

@bgiori bgiori commented Apr 2, 2024

Summary

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: NO

Copy link

@Mercy811 Mercy811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Brian for adding it! Overall looks good to me.

How about adding NSPrivacyTrackingDomains?

static let serverUrl: String = "https://api.lab.amplitude.com"
static let flagsServerUrl: String = "https://flag.lab.amplitude.com"

These endpoint are used by default, so that users don't need to add them by themselves.

@bgiori bgiori merged commit ea9ceed into main Apr 8, 2024
2 checks passed
@bgiori bgiori deleted the add-privacy-manifest branch April 8, 2024 22:12
github-actions bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.13.3](v1.13.2...v1.13.3) (2024-04-09)

### Bug Fixes

* add privacy manifest ([#48](#48)) ([ea9ceed](ea9ceed))
Copy link

github-actions bot commented Apr 9, 2024

🎉 This PR is included in version 1.13.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants